RFR [8u60]: 8073944: Simplify ArgumentsExt and remove unneeded functionallity

Stefan Johansson stefan.johansson at oracle.com
Mon Mar 2 10:17:52 UTC 2015


Thanks for the review David,

On 2015-02-27 01:15, David Holmes wrote:
> On 26/02/2015 9:13 PM, Stefan Johansson wrote:
>> Hi,
>>
>> Please review this small changes for:
>> https://bugs.openjdk.java.net/browse/JDK-8073944
>>
>> Webrev:
>> http://cr.openjdk.java.net/~sjohanss/8073944/hotspot.00/
>>
>> Summary:
>> The removed functionality was added as part of JDK-8057623, but is no
>> longer needed.
>
> Given it hasn't been in long, removing it should not be an issue - 
> particularly for 8u - but it suggests we need to give more thought to 
> the form of these extension points when we add them.
>
I agree, that we should have good reasons for adding these hooks and 
that we should add them in way that they allow further extensions. I 
this case we had a requirement for 8u40 that has been changed to 8u60.

Thanks,
Stefan
> Reviewed.
>
> Thanks,
> David
>
>
>> Thanks,
>> Stefan



More information about the hotspot-dev mailing list