RFR(M): 8073315: Enable gcc -Wtype-limits and fix upcoming issues.

Kim Barrett kim.barrett at oracle.com
Tue Mar 3 02:02:02 UTC 2015


On Mar 2, 2015, at 4:48 PM, Lindenmaier, Goetz <goetz.lindenmaier at sap.com> wrote:
> 
> I will look into heapRetionSet.cpp tomorrow.

OK.  If it turns out to be hard to prove the tests should be > rather than >= (e.g. proving that
if !is_empty() then those values must *not* be zero), then I’d be ok with just having the test
simplified, and maybe file a CR to investigate further.

> About the comment, I don't feel good documenting something
> that's not true, as the other implementations still return 0 on 
> error.

OK.  I’ll adjust the corresponding comment in the CR I filed.

> I can't see where that file is coming from, I sure never did a 
> hg add for it.  It used to be there. An artefact of pull & rebase?  
> I'll remove it again...

Can’t help you there; just make sure it’s gone when pushing.



More information about the hotspot-dev mailing list