RFA: 8074349: AARCH64: C2 generates poor code for some byte and character stores

[Vladimir Kozlov]

On 3/3/15 10:19 AM, Andrew Haley wrote:
> On 03/03/2015 06:16 PM, Vladimir Kozlov wrote:
>> Looks good.
>>
>> Since it is platform specific code new rule allow you to push changes yourself.
>
> OK.
>
>> Make sure you have jcheck enabled - ~/.hgrc has
>>
>> [extensions]
>> jcheck=/<your path to jcheck>/jcheck.py
>> [hooks]
>> pretxnchangegroup=python:jcheck.hook
>> pretxncommit=python:jcheck.hook
>>
>> See http://openjdk.java.net/projects/code-tools/jcheck/
>
> Yes, long since.

Good.

>
>> And, please, make sure changeset has correct header:
>>
>> 8074349: AARCH64: C2 generates poor code for some byte and character stores
>> Summary: Use iRegIorL2I as the source operand for all stores of int size or less.
>> Reviewed-by: kvn
>>
>> See http://openjdk.java.net/guide/producingChangeset.html
>
> If this header is wrong, you'll have to tell me where.  I can't see it.

It is example what the header should be for this fix. It is correct one.

Your patch in webrev does not have a header so I don't know what you have.

Regards,
Vladimir

>
> Thanks,
> Andrew.
>
>