RFR: 8013393: Merge templateTable_x86 32 and 64 bit files into one file.

John Rose john.r.rose at oracle.com
Wed Mar 4 02:13:28 UTC 2015


On Mar 3, 2015, at 1:39 PM, Max Ockner <max.ockner at oracle.com> wrote:
> 
> I have made all of the changes recommended by Chris and John.  I realize there are plenty of further cleanups and optimizations that I could make, but I think this is nearing a good stopping point for now. We can always clean it up more later. What do you think?
> 
> new webrev:   cr.openjdk.java.net/~coleenp/8013393 <http://cr.openjdk.java.net/~coleenp/8013393>
> tested with nsk.jvmti.testlist

I think the webrev is:   cr.openjdk.java.net/~coleenp/8013393.02

It looks good.  The balance of shared code, #ifdefs, and LP64 macros is very reasonable now.

The template '_new' uses register allocations from 32-bit on 64-bit,
and so there is a slight chance of regression there.
I didn't notice that of the other templates.

You can count me as a reviewer.

— John


More information about the hotspot-dev mailing list