RFR (S): 8074726: Update source and target version used when compiling hotspot class files

[David Holmes]

Hi Mikael,

On 10/03/2015 5:28 AM, Mikael Vidstedt wrote:
>
> The Java class files under hotspot/ are currently compiled using
> "-source 6 -target 6" which generates unnecessarily old class files and
> also prints out warning messages doing so. This change does two things:
>
> * bumps the default version used to "-source 8 -target 8"
> * uses the BOOT_JDK_SOURCETARGET from the top level build system if it
> has been set (typically to "-source 8 -target 8")

Makes sense to auto update this. The use of 6 was a "manual" update:

https://bugs.openjdk.java.net/browse/JDK-6873059

> Tested through JPRT, the serviceability/sa regression tests as well as
> some Oracle internal tests.
>
> http://cr.openjdk.java.net/~mikael/webrevs/8074726/webrev.00/webrev/
>
> The change in make/defs.gmk is needed to pass the relevant option
> through to the jvmti docs compilation.

Hmmm. That suggests something is amiss as the value should be coming 
through spec.gmk and shouldn't need to be passed directly to all the 
sub-makes via MAKE_ARGS. The generated jvmti.make includes the generated 
flags.make which includes the configured hotspot-spec.gmk which includes 
spec.gmk, which defines BOOT_JDK_SOURCETARGET.

Ah, but the jvmtidocs target doesn't start with the generated 
jvmti.make, it uses the repo version:

./linux/Makefile:       $(MAKE) -f 
$(GAMMADIR)/make/$(OSNAME)/makefiles/jvmti.make $(MFLAGS) 
$(BUILDTREE_VARS) JvmtiOutDir=$(SUBDIR_DOCS) BUILD_FLAVOR=product jvmtidocs

Hmmm - not happy but either it gets fixed once by MAKE_FLAGS, or in 
every platform Makefile by MFLAGS. <sigh> Ok.

Thanks,
David


> Cheers,
> Mikael
>