RFR: JDK-8074459 - Flags handling memory sizes should be of type size_t

Jesper Wilhelmsson jesper.wilhelmsson at oracle.com
Thu Mar 19 16:09:29 UTC 2015


Hi,

The original change has been approved by both Kim and Thomas and is good to go.

It was decided to include the fix for the log rotation bug discovered in this 
review as well. A new webrev including this fix is available here:

http://cr.openjdk.java.net/~jwilhelm/8074459/webrev.03/

The only change compared to the previous webrev is the bugfix in 
src/share/vm/utilities/ostream.hpp

Thanks,
/Jesper


Kim Barrett skrev den 16/3/15 18:40:
> On Mar 13, 2015, at 8:45 AM, Jesper Wilhelmsson <jesper.wilhelmsson at oracle.com> wrote:
>>
>> Hi Kim and Thomas,
>>
>> Thanks for the reviews!
>>
>> A new webrev is available here:
>>
>> http://cr.openjdk.java.net/~jwilhelm/8074459/webrev.02/
>>
>> There is an incremental diff as well with the latest changes suggested by you.
>
> Looks good.
>
> Please remember to file CR for log rotation test.
>


More information about the hotspot-dev mailing list