RFR: 8074718: Merged templateTable_x86 header files for 32/64 bits.

Max Ockner max.ockner at oracle.com
Tue Mar 24 17:32:03 UTC 2015


Hello all,
Please review this small change.

Bug:  https://bugs.openjdk.java.net/browse/JDK-8074718
Webrev: 
http://cr.openjdk.java.net/~mockner/8074718/src/share/vm/interpreter/templateTable.hpp.cdiff.html
Summary: The templateTable_x86 hpp files for 32 and 64 bits have been 
merged. Just a couple of notes:

(1) I would prefer to combine the two conditions which include 
templateTable_x86.hpp if possible, but I'm not comfortable fiddling with 
the TARGET_ARCH_MODEL labels.
I was hoping to use TARGET_ARCH_MODEL_x86 to encompass both 
TARGET_ARCH_MODEL_x86_64 and TARGET_ARCH_MODEL_x86_32, but I don't think 
it exists. Any suggestions?

(2) templateTable_x86.hpp is the updated file that will be kept. 
templateTable_x86_32.hpp and templateTable_x86_64.hpp are copies of 
templateTable_x86.hpp, and still exist for reviewing purposes. They will 
be removed before this is committed.

Tested with jtreg runtime tests.

Thanks,
Max


More information about the hotspot-dev mailing list