RFR (xs) 8075967: Zero interpreter asserts for SafeFetch<32, N> calls in ObjectMonitor

Severin Gehwolf sgehwolf at redhat.com
Wed Mar 25 18:29:32 UTC 2015


Hi Coleen,

Thanks for this!

On Wed, 2015-03-25 at 13:53 -0400, Coleen Phillimore wrote:
> Summary: Implement SafeFetchX unsafely and make CanUseSafeFetchX false 
> for Zero
> 
> Also, this fixes a couple other minor issues.
> 
> Ran jdk9 jck tests with one timeout.  hotspot/runtime jtreg tests don't 
> run because Zero doesn't support UseCompressedOops (not sure why) and 
> CDS (know why).
> 
> open webrev at http://cr.openjdk.java.net/~coleenp/8075967/
> bug link https://bugs.openjdk.java.net/browse/JDK-8075967

Disclaimer: Not a reviewer.

While I'd have preferred correct (safe) SafeFetchX implementations (or
remove them for Zero) I don't see how we could do this for Zero in an
arch-independent way. AFAIK, getting/setting the PC via ucontext is
machine dependent and Zero may be running on any linux architecture
where GCC is available.

Changes look fine to me.

Cheers,
Severin

> Thanks,
> Coleen





More information about the hotspot-dev mailing list