RFR(s): 8076012 - SA don't support flags of type size_t

[David Holmes]

On 26/03/2015 7:25 AM, Kim Barrett wrote:
> On Mar 25, 2015, at 3:10 PM, Jesper Wilhelmsson <jesper.wilhelmsson at oracle.com> wrote:
>>
>> Hi,
>>
>> Please review this fix for the serviceability agent to support flags of type size_t.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8076012
>> Webrev: http://cr.openjdk.java.net/~jwilhelm/8076012/webrev.00/
>>
>> This bug is currently blocking the GC repository from being synced with main after the change to make a bunch of flags size_t.
>
>
> Looks good.
>
> ------------------------------------------------------------------------------
> agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java
> Changing "a" to "an"
>   179            Assert.that(isIntx(), "not an intx flag!");
>   190            Assert.that(isUIntx(), "not an uintx flag!");
>
> Nit-picking: I think the first is correct, but not the second.

Depends on how you pronounce uintx :)

David

> And no, I don't need another webrev if you change this.
>
> ------------------------------------------------------------------------------
>