RFR: 8074718: Merged templateTable_x86 header files for 32/64 bits.

[Max Ockner]

Dean,

On 3/24/2015 4:31 PM, Dean Long wrote:
> On 3/24/2015 10:32 AM, Max Ockner wrote:
>> Hello all,
>> Please review this small change.
>>
>> Bug:  https://bugs.openjdk.java.net/browse/JDK-8074718
>> Webrev: 
>> http://cr.openjdk.java.net/~mockner/8074718/src/share/vm/interpreter/templateTable.hpp.cdiff.html
>> Summary: The templateTable_x86 hpp files for 32 and 64 bits have been 
>> merged. Just a couple of notes:
>>
>> (1) I would prefer to combine the two conditions which include 
>> templateTable_x86.hpp if possible, but I'm not comfortable fiddling 
>> with the TARGET_ARCH_MODEL labels.
>> I was hoping to use TARGET_ARCH_MODEL_x86 to encompass both 
>> TARGET_ARCH_MODEL_x86_64 and TARGET_ARCH_MODEL_x86_32, but I don't 
>> think it exists. Any suggestions?
>>
>
> You could use TARGET_ARCH_x86, but then it doesn't match all the 
> platforms using TARGET_ARCH_MODEL.  Or you could define 
> TEMPLATETABLE_MD_HPP and not worry about TARGET macros at all.
>
> dl
>

The main reason I had hoped for a better label was to avoid breaking the 
symmetry of the existing list. Unless anyone disagrees, I will keep this 
section as is.

Thanks,
Max
>> (2) templateTable_x86.hpp is the updated file that will be kept. 
>> templateTable_x86_32.hpp and templateTable_x86_64.hpp are copies of 
>> templateTable_x86.hpp, and still exist for reviewing purposes. They 
>> will be removed before this is committed.
>>
>> Tested with jtreg runtime tests.
>>
>> Thanks,
>> Max
>