RFR: 8075735: Missing include causes minimal build failure

Christian Thalinger christian.thalinger at oracle.com
Mon Mar 30 18:29:14 UTC 2015


> On Mar 24, 2015, at 6:29 AM, Volker Simonis <volker.simonis at gmail.com> wrote:
> 
> When do we finally run NON-PCH builds in JPRT?

I second that.

> 
> That's long overdue. I think it will save us from a lot of problems
> llike this one at the minimal cost of some cpu-cycles.
> 
> Regards,
> Volker
> 
> 
> On Tue, Mar 24, 2015 at 11:52 AM, Stefan Johansson
> <stefan.johansson at oracle.com> wrote:
>> Thanks for the reviews Joe, David and Stefan.
>> 
>> I've updated the bug with info on when this was introduced. The reason it
>> was not caught by JPRT is because it uses pre-compiled headers, and it
>> probably hides the problem. In my local builds I disable pre-compiled
>> headers and for minimal that shows the problem.
>> 
>> Thanks,
>> Stefan
>> 
>> 
>> On 2015-03-24 10:18, Stefan Karlsson wrote:
>>> 
>>> On 2015-03-23 16:06, Stefan Johansson wrote:
>>>> 
>>>> Hi,
>>>> 
>>>> Please review this small change to fix:
>>>> https://bugs.openjdk.java.net/browse/JDK-8075735
>>>> 
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~sjohanss/8075735/hotspot.00/
>>> 
>>> 
>>> Looks good.
>>> 
>>> StefanK
>>> 
>>>> 
>>>> Summary:
>>>> Minimal1 currently does not build in the hs-gc repo. The cause is a
>>>> missing include in thread.cpp, which is added by the proposed change.
>>>> 
>>>> Testing:
>>>> Verified that minimal1 builds and run after the change.
>>>> 
>>>> Thanks,
>>>> Stefan
>>> 
>>> 
>> 



More information about the hotspot-dev mailing list