RFR(XS): 8079545: [TESTBUG] hotspot_basicvmtest doesn't fail even if VM crashes

Christian Tornqvist christian.tornqvist at oracle.com
Thu May 7 00:30:57 UTC 2015


Hi Mikael,

Looks good, thanks for fixing this.

Thanks,
Christian

-----Original Message-----
From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Mikael Vidstedt
Sent: Wednesday, May 6, 2015 8:24 PM
To: hotspot-dev at openjdk.java.net
Subject: RFR(XS): 8079545: [TESTBUG] hotspot_basicvmtest doesn't fail even if VM crashes


Please review this small fix which fixes a problem introduced by 8078017[1].

Bug: https://bugs.openjdk.java.net/browse/JDK-8079545
Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8079545/webrev.00/webrev/

The problem is that the exit value from the inner Makefile invocation is not being checked, so even if one of the tests fail the outer make will not signal en error. The exit code needs to be explicitly checked.

Cheers,
Mikael

[1] https://bugs.openjdk.java.net/browse/JDK-8078017




More information about the hotspot-dev mailing list