RFR(XXL): 8079792: GC directory structure cleanup

[David Holmes]

On 13/05/2015 9:22 PM, Per Liden wrote:
> Hi David,
>
> On 2015-05-13 11:03, David Holmes wrote:
>> Hi Per,
>>
>> On 13/05/2015 6:29 PM, Per Liden wrote:
>>>> On 12 May 2015, at 17:24, Stefan Karlsson
>>>> <stefan.karlsson at oracle.com> wrote:
>>>> On 2015-05-12 12:16, Per Liden wrote:
>>>>
>>>> http://cr.openjdk.java.net/~pliden/8079792/webrev.0/make/excludeSrc.make.udiff.html
>>>>
>>>>
>>>>
>>>> The gc_shared_keep variable was changed to include almost all files
>>>> in gc/shared, but there a few files in gc/shared that are not listed.
>>>> Most of them should probably be moved to GC specific directories.
>>>>
>>>> With those files moved, we might want to consider removing the
>>>> gc_shared_keep variable entirely.
>>>
>>>
>>> Agree, I’ll remove gc_shared_keep and move the [hgc]SpaceCounters.* to
>>> their respective directory (I had missed that those are actually
>>> GC-specific).
>>
>> Just as a sanity check can you do a local build that includes the
>> minimal VM and verify that there are no unexpected gc related .o files
>> produced.
>
> There are two files (concurrentGCThread.o and plab.o) we compile for
> minimal, which aren't needed and symbols in there are never referenced.
> But since they still make libjvm.so grow a little bit I'll append those
> two to the exclude list. So instead of listing all but two files in a
> keep list, we just list the two in the exclude list.

Thanks!

David

> cheers,
> /Per
>
>>
>> Thanks,
>> David
>>
>>> /Per
>>>
>>>>
>>>> thanks,
>>>> StefanK
>>>>
>>>>>
>>>>> Here's the same webrev split into the following pieces:
>>>>>
>>>>> - Change to cpp/hpp files
>>>>> http://cr.openjdk.java.net/~pliden/8079792/webrev.0-hotspot/
>>>>>
>>>>> - Changes to makefiles
>>>>> http://cr.openjdk.java.net/~pliden/8079792/webrev.0-make/
>>>>>
>>>>> - Changes to SA
>>>>> http://cr.openjdk.java.net/~pliden/8079792/webrev.0-sa/
>>>>>
>>>>> - Changes to jtreg tests
>>>>> http://cr.openjdk.java.net/~pliden/8079792/webrev.0-test/
>>>>>
>>>>>
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8079792
>>>>>
>>>>> Testing: JPRT, Aurora adhoc GC nightly, bigapps
>>>>>
>>>>> cheers,
>>>>> /Per
>>>>>
>>>>> [1]
>>>>> http://mail.openjdk.java.net/pipermail/hotspot-dev/2015-May/018439.html
>>>>>
>>>>
>>>