Corrected: RFR 8059557 (XL): Validate JVM Command-Line Flag Arguments

[Gerard Ziemski]

hi Dmitry,

Thank you for taking the time to review this considerable change for an 
n-th time now :-)

On 5/18/2015 7:55 AM, Dmitry Dmitriev wrote:
> Hi Gerard,
>
> Can you please correct format string for jio_fprintf function in the 
> following functions(all from 
> src/share/vm/runtime/commandLineFlagRangeList.cpp):
> Flag::Error check_intx(intx value, bool verbose = true)
> Portion of format string from "intx %s = %ld is outside ..." to "intx 
> %s = "INTX_FORMAT" is outside ..."
>
> Flag::Error check_uintx(uintx value, bool verbose = true)
> Portion of format string from "uintx %s = %lu is outside ..." to 
> "uintx %s = "UINTX_FORMAT" is outside ..."
>
> Flag::Error check_uint64_t(uint64_t value, bool verbose = true)
> Portion of format string from "uint64_t %s = %lu is outside ..." to 
> "uint64_t %s = "UINT64_FORMAT" is outside ..."

Are you sure you are looking at the current webrev? I know I sent you 
many before internally, but the rev0 and rev1 seem to already include 
the changes you request?

I have, however, modified CICompilerCount range max value as you 
requested, ie.  to "max_jint" instead of "max_intx" to avoid a potential 
overflow issue you found.


cheers