RFR 8081202 C++11 requires a space between literal and identifier

[Kim Barrett]

On May 27, 2015, at 10:15 PM, bill pittore <bill.pittore at oracle.com> wrote:
> 
> Thanks Kim. I fixed most of the alignments.  One or two lines were so far off that I just left them as outliers so I didn't have to move all the lines over. Updated the webrev: http://cr.openjdk.java.net/~bpittore/8081202/hotspot-webrev.01/
> 
> thanks,
> bill

Looks good.

> 
> On 5/27/2015 8:18 PM, Kim Barrett wrote:
>> On May 27, 2015, at 6:36 PM, bill pittore <bill.pittore at oracle.com> wrote:
>>> As part of some work I'm doing I had to fix this particular problem with string literals and macros.  A few people mentioned to me that it would be a good idea to just get this pushed into JDK 9 so here is the webrev.  I tested this with gcc 5.1.0 using -std=c++11 option as well as Visual Studio 2015 RC.  Note that there are other issues WRT building using C++11 but this webrev only deals with the string literal issue.  In my workspace, hg diff -w shows no files with diffs meaning that all the changes in this webrev are whitespace only.  Ran through JPRT with no issues. This will most likely be pushed after the hs-gc repo effectively merges into hs-rt repo, sometime in the next week or so pending approval.
>>> 
>>> http://cr.openjdk.java.net/~bpittore/8081202/
>>> 
>>> thanks,
>>> bill
>> ------------------------------------------------------------------------------
>> src/share/vm/gc/g1/concurrentMark.inline.hpp
>>  200          err_msg("Trying to access not available bitmap " PTR_FORMAT            \
>>  201                  " corresponding to " PTR_FORMAT " (%u)",                        \
>> 
>> Line continuation backslashes no longer lined up with others in the
>> same macro expansion.
>> 
>> ------------------------------------------------------------------------------
>> src/share/vm/prims/methodHandles.cpp
>> 1365 static JNINativeMethod MHN_methods[] = {
>> ...
>> 
>> The FN_PTR parameters in the initializers used to be aligned.
>> 
>> ------------------------------------------------------------------------------
>> src/share/vm/prims/perf.cpp
>>  301 static JNINativeMethod perfmethods[] = {
>> ...
>> 
>> The FN_PTR parameters in the initializers used to be aligned.
>> 
>> ------------------------------------------------------------------------------
>> src/share/vm/prims/unsafe.cpp
>> 
>> Lots of FN_PTR initializers are no longer aligned.
>> 
>> ------------------------------------------------------------------------------
>> 
>> Otherwise, looks good.