[9] RFR(XS) 8141138: Zero fails to build

[Coleen Phillimore]

On 11/3/15 10:29 AM, Severin Gehwolf wrote:
> Hi Coleen,
>
> On Mon, 2015-11-02 at 13:05 -0500, Coleen Phillimore wrote:
>> Hi,
>>
>> This change looks fine.
> Thanks for the review.
>
>> I can't build Zero anymore because of some
>> build change that doesn't work for me.  If I can get that figured
>> out,
>> I'll sponsor this and the other change for you.
> Oh that's unfortunate. Please let me know if there is something I can
> do to fix it.
>
>> The build tries to pass -lffi even though I gave it an explicit
>> libffi
>> directory.
> I see. Just to clarify: you've used "--with-libffi" or "--with-libffi-
> include and --with-libffi-lib", right? I have libffi in a well known
> system location (package libffi on Fedora) which does not seem to need
> this.

I have ubuntu and sudo apt-get install puts libffi in these places 
(which I guess aren't standard).

--with-libffi-lib=/usr/lib/x86_64-linux-gnu 
--with-libffi-include=/usr/include/x86_64-linux-gnu

This gets further but I now have a compilation error

/usr/include/x86_64-linux-gnu/asm/param.h:1:31: fatal error: 
asm-generic/param.h: No such file or directory
  #include <asm-generic/param.h>
                                ^
compilation terminated.
In file included from 
/scratch/cphillim/gcc4.8.2-OEL5.5/x86_64-unknown-linux-gnu/sysroot/usr/include/linux/param.h:4:0,
                  from /usr/include/x86_64-linux-gnu/bits/param.h:28,
                  from /usr/include/x86_64-linux-gnu/sys/param.h:31,
                  from 
/home/cphillim/hg.local/jdk9.zero/hotspot/src/os/linux/vm/jvm_linux.h:45,

Which looks like it's caused by the --with-libffi-include settting.

Coleen
>
> Cheers,
> Severin
>
>> Coleen
>>
>> On 11/2/15 11:41 AM, Severin Gehwolf wrote:
>>> Hi,
>>>
>>> Could somebody please review and - if approved - sponsor this
>>> fairly
>>> trivial change?
>>>
>>> A recent checkout of the hs-rt tree fails to build the Zero
>>> variant[1]
>>> for the following reasons:
>>>
>>>    * JDK-8136421 (Java Level JVM Compiler Interface) did not update
>>> two
>>>      files: src/cpu/zero/vm/relocInfo_zero.cpp
>>>      and src/cpu/zero/vm/compiledIC_zero.cpp. The signature
>>>      of emit_to_interp_stub() has changed. This patch updates it for
>>> Zero
>>>      too. poll_return_Relocation::fix_relocation_after_move has been
>>>      removed from header files. This patch removes the Zero stub as
>>> well.
>>>    * JDK-8139163 (InstanceKlass::cast passes through NULL) removed
>>> the
>>>      k_entry variable. I've updated the code to use the new "ik"
>>> variable
>>>      instead.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8141138
>>> webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8141138/we
>>> brev.00/
>>>
>>> Thanks,
>>> Severin
>>>
>>> [1] http://builder.classpath.org/jenkins/job/OpenJDK9_hs_rt_Zero/18
>>> 2/