RFR (s) 8141570: Fix Zero interpreter build for --disable-precompiled-headers

Severin Gehwolf sgehwolf at redhat.com
Fri Nov 6 09:48:21 UTC 2015


Hi Coleen,

On Thu, 2015-11-05 at 20:33 -0500, Coleen Phillimore wrote:
> With the RedHat compiler that I'm using g++ (GCC) 4.8.2 20140120 (Red
> Hat 4.8.2-16)
> these additional includes are needed to compile without precompiled
> headers.

Reproduced on Zero fastdebug/slowdebug builds. Zero release builds
didn't have that problem. Just an FYI.

> open webrev at http://cr.openjdk.java.net/~coleenp/8141570.01/
> bug link https://bugs.openjdk.java.net/browse/JDK-8141570

With the above patch the build problem on fastdebug/slowdebug without
precompiled headers goes away. Thanks for fixing it!

+1

Cheers,
Severin

> I'm not sure why allocation.inline.hpp is needed unless the virtual 
> destructor in src/share/vm/gc/shared/plab.hpp PLABStats implicitly
> calls 
> delete.
> 
> Tested with compiles of Zero plus plain linux
> debug/fastdebug/product.
> 
> Thanks,
> Coleen



More information about the hotspot-dev mailing list