RFR (M): 8138983: Runtime: implement ranges for Shared*** flags

gerard ziemski gerard.ziemski at oracle.com
Fri Nov 6 15:58:45 UTC 2015


hi all,

Please review this final fix for JEP-245

We implement the remaining runtime flags in the Shared* family.

Summary of changes:

#1 core fix - we factor out the constants to be used in the ranges

src/share/vm/classfile/compactHashtable.cpp
src/share/vm/memory/metaspace.cpp
src/share/vm/memory/metaspaceShared.hpp
src/share/vm/runtime/globals.hpp


#2 we increase default sizes of range and constraint tables to minimize mallocs

src/share/vm/runtime/commandLineFlagConstraintList.cpp
src/share/vm/runtime/commandLineFlagRangeList.cpp


#3 we fix a bug that I run into the OptionsValidation test framework while working

test/runtime/CommandLine/OptionsValidation/common/optionsvalidation/IntJVMOption.java


#4 we add functionality to OptionsValidation test framework that we later use

test/runtime/CommandLine/OptionsValidation/common/optionsvalidation/JVMOptionsUtils.java


#5 we cleanup and extend the existing test to detect a case where we get out of range value

test/runtime/SharedArchiveFile/LimitSharedSizes.java


The fix passes RBT "hotspot/test/:hotspot_all,testlist,noncolo.testlist --add-tonga-keyword quick” and JPRT “hotspot" tests

References:

     bug link: https://bugs.openjdk.java.net/browse/JDK-8138983
  open webrev: http://cr.openjdk.java.net/~gziemski/8138983_rev0


hg_stat:

  src/share/vm/classfile/compactHashtable.cpp                                              |    2 +-
  src/share/vm/memory/metaspace.cpp                                                        |   30 --
  src/share/vm/memory/metaspaceShared.hpp                                                  |   19 +-
  src/share/vm/runtime/commandLineFlagConstraintList.cpp                                   |    2 +-
  src/share/vm/runtime/commandLineFlagRangeList.cpp                                        |    2 +-
  src/share/vm/runtime/globals.hpp                                                         |   63 +++++-
  test/runtime/CommandLine/OptionsValidation/common/optionsvalidation/IntJVMOption.java    |    4 +-
  test/runtime/CommandLine/OptionsValidation/common/optionsvalidation/JVMOptionsUtils.java |   81 +++++++
  test/runtime/SharedArchiveFile/LimitSharedSizes.java                                     |  180 +++++++++-------
  9 files changed, 242 insertions(+), 141 deletions(-)






More information about the hotspot-dev mailing list