RFR (M): 8138983: Runtime: implement ranges for Shared*** flags

[gerard ziemski]

Thank you for the review!

On 11/06/2015 02:36 PM, Dmitry Dmitriev wrote:
> Hi Gerard,
>
> Thank you for fixing bug in the framework.
> Overall looks good to me, just few comments:
> 1) src/share/vm/runtime/globals.hpp
>
> Line 536: typo - "metspace"

Fixed.


> 2) src/share/vm/memory/metaspace.cpp
>
> Deleted code calls 'align_size_up' on lines 3247, 3252 to align minimal value for SharedMiscDataSize and
> SharedMiscCodeSize, but now low range for these flags is not aligned. Is it okay?

The range function compares the min with the value before any alignment takes place, so we're good (we're not mixing 
comparison of aligned vs unaligned values here), but good question.


> 3) JVMOptionsUtils.java
>
> Line 40: can you please put "import java.math.BigDecimal;" between "import java.io.Reader;" and "import
> java.util.ArrayList;"
> Line 70: bad indentation
> Lines 101, 104, 107: can you please add space between ";" and "//".

Fixed.


> 4) LimitSharedSizes.java
>
> Lines 63-69(SharedSizeTestData constructor): can you please correct indentation to the 4 spaces.

Fixed.

I will post rev1 up shortly.


cheers

>
> Thank you,
> Dmitry
>
> On 06.11.2015 18:58, gerard ziemski wrote:
>>
>> hi all,
>>
>> Please review this final fix for JEP-245
>>
>> We implement the remaining runtime flags in the Shared* family.
>>
>> Summary of changes:
>>
>> #1 core fix - we factor out the constants to be used in the ranges
>>
>> src/share/vm/classfile/compactHashtable.cpp
>> src/share/vm/memory/metaspace.cpp
>> src/share/vm/memory/metaspaceShared.hpp
>> src/share/vm/runtime/globals.hpp
>>
>>
>> #2 we increase default sizes of range and constraint tables to minimize mallocs
>>
>> src/share/vm/runtime/commandLineFlagConstraintList.cpp
>> src/share/vm/runtime/commandLineFlagRangeList.cpp
>>
>>
>> #3 we fix a bug that I run into the OptionsValidation test framework while working
>>
>> test/runtime/CommandLine/OptionsValidation/common/optionsvalidation/IntJVMOption.java
>>
>>
>> #4 we add functionality to OptionsValidation test framework that we later use
>>
>> test/runtime/CommandLine/OptionsValidation/common/optionsvalidation/JVMOptionsUtils.java
>>
>>
>> #5 we cleanup and extend the existing test to detect a case where we get out of range value
>>
>> test/runtime/SharedArchiveFile/LimitSharedSizes.java
>>
>>
>> The fix passes RBT "hotspot/test/:hotspot_all,testlist,noncolo.testlist --add-tonga-keyword quick” and JPRT “hotspot"
>> tests
>>
>> References:
>>
>>     bug link: https://bugs.openjdk.java.net/browse/JDK-8138983
>>  open webrev: http://cr.openjdk.java.net/~gziemski/8138983_rev0
>>
>>
>> hg_stat:
>>
>>  src/share/vm/classfile/compactHashtable.cpp |    2 +-
>>  src/share/vm/memory/metaspace.cpp |   30 --
>>  src/share/vm/memory/metaspaceShared.hpp |   19 +-
>>  src/share/vm/runtime/commandLineFlagConstraintList.cpp |    2 +-
>>  src/share/vm/runtime/commandLineFlagRangeList.cpp |    2 +-
>>  src/share/vm/runtime/globals.hpp |   63 +++++-
>>  test/runtime/CommandLine/OptionsValidation/common/optionsvalidation/IntJVMOption.java |    4 +-
>>  test/runtime/CommandLine/OptionsValidation/common/optionsvalidation/JVMOptionsUtils.java |   81 +++++++
>>  test/runtime/SharedArchiveFile/LimitSharedSizes.java |  180 +++++++++-------
>>  9 files changed, 242 insertions(+), 141 deletions(-)
>>
>>
>>
>>
>
>