RFR: 8077571: ObjPtrQueue is poorly named

Kim Barrett kim.barrett at oracle.com
Mon Nov 9 20:36:06 UTC 2015


On Nov 9, 2015, at 4:39 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
> 
> Hi,
> 
> On Fri, 2015-11-06 at 17:09 -0500, Kim Barrett wrote:
>> [Sending to hotspot-dev because this touches runtime and compiler
>> files too. I'm particularly looking for a compiler person for the
>> change to HotSpotVMConfig.java.]
>> 
>> Please review this rename of ObjPtrQueue to SATBMarkQueue.  This
>> cleanup is being done in preparation for some further changes that
>> will make the name more widely used.
>> 
>> Probably the satbQueue.[ch]pp files should be renamed to
>> satbMarkQueue.[ch]pp.  I've not made such a change because my
>> understanding is that mercurial mq doesn't really understand file
>> renames.
>> 
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8077571
>> 
>> Webrev:
>> http://cr.openjdk.java.net/~kbarrett/8077571/webrev.00/
>> 
>> Testing:
>> JPRT
>> 
> 
>  looks good to me. Just rename the files, mercurial understands
> renames.

Thanks, Thomas.

Yes, more reading about mq and I understand now…

I’ll take care of the rename too, as you and Bengt requested.



More information about the hotspot-dev mailing list