RFR (XS) : 8141641: Runtime: implement range for ErrorLogTimeout

gerard ziemski gerard.ziemski at oracle.com
Wed Nov 11 16:56:37 UTC 2015


Good point - the goal of the feature is not to allow a crash, and in this case range of 0..UINT_MAX works.

Thank you for the review.


cheers

On 11/10/2015 08:43 PM, David Holmes wrote:
> On 11/11/2015 5:34 AM, gerard ziemski wrote:
>>
>> hi all,
>>
>> Please review this small fix for JEP-245, which implements range for the
>> last new runtime flag.
>>
>>      bug: https://bugs.openjdk.java.net/browse/JDK-8141641
>>   webrev: http://cr.openjdk.java.net/~gziemski/8141641_rev0
>
> This seems an artificial constraint. Why should I not be able to specify 0 or UINT_MAX? A range check is for validity
> not sensibility, and all values are valid here.
>
> David


More information about the hotspot-dev mailing list