RFR (XS) : 8141641: Runtime: implement range for ErrorLogTimeout
gerard ziemski
gerard.ziemski at oracle.com
Thu Nov 12 19:10:01 UTC 2015
Thank you Coleen for the review.
On 11/12/2015 12:30 PM, Coleen Phillimore wrote:
>
> Looks good.
>
> What is
>
> *! #define INITIAL_RANGES_SIZE_205_*
We don't have to adjust that size - the table is dynamic and will adjust as needed, but chanhging this constants when
adding new ranges will make sure we don't have to realloc, which should impact startup time.
cheers
>
>
> Do you have to update this whenever you add a range?
>
> Thanks,
> Coleen
>
> On 11/12/15 1:26 PM, gerard ziemski wrote:
>> hi all,
>>
>> I have updated the fix with rev1, incorporating the feedback from David:
>>
>> - Use trivial range
>>
>>
>> http://cr.openjdk.java.net/~gziemski/8141641_rev1
>>
>>
>> cheers
>>
>> On 11/10/2015 01:34 PM, gerard ziemski wrote:
>>>
>>> hi all,
>>>
>>> Please review this small fix for JEP-245, which implements range for the last new runtime flag.
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8141641
>>> webrev: http://cr.openjdk.java.net/~gziemski/8141641_rev0
>>>
>>>
>>> Thank you.
>
>
More information about the hotspot-dev
mailing list