RFR (XS) : 8141641: Runtime: implement range for ErrorLogTimeout

[Dmitry Dmitriev]

Hi Gerard,

Several comments:
1) I beleive that David mean UINT_MAX, i.e. without "x", because it 
always 32-bit and can avoid overflow of resulting value. Thus, I think 
that upper range should be "max_juint".

2) Also, in revision 0 you correct using of ErrorLogTimeout to match 
definition by removing "60" from call to the "os::sleep" in 
src/share/vm/runtime/thread.cpp. Did something changed between rev0 and 
rev1?

3) Also, David suggested to wrap constants in multiplication in 
src/share/vm/runtime/thread.cpp into CONST64 to avoid possible 
overflows, i.e.:
os::sleep(this, ErrorLogTimeout * CONST64(1000), false);

Thanks,
Dmitry

On 12.11.2015 21:26, gerard ziemski wrote:
> hi all,
>
> I have updated the fix with rev1, incorporating the feedback from David:
>
> - Use trivial range
>
>
> http://cr.openjdk.java.net/~gziemski/8141641_rev1
>
>
> cheers
>
> On 11/10/2015 01:34 PM, gerard ziemski wrote:
>>
>> hi all,
>>
>> Please review this small fix for JEP-245, which implements range for 
>> the last new runtime flag.
>>
>>      bug: https://bugs.openjdk.java.net/browse/JDK-8141641
>>   webrev: http://cr.openjdk.java.net/~gziemski/8141641_rev0
>>
>>
>> Thank you.