RFR (M): 8138983: Runtime: implement ranges for Shared*** flags

[Dmitry Dmitriev]

Hi Gerard,

Revision 3 looks good to me!

Thanks,
Dmitry

On 12.11.2015 21:21, gerard ziemski wrote:
> hi all,
>
> I have updated the fix with rev3, incorporating the feedback from 
> Jiangli:
>
> - After considering the choices I decided to use MIN when calculating 
> the range's MAX values. This seems to be the most correct, however, 
> the SQE testing framework will need to have those flags disabled for 
> now. I filed issue JDK-8142874 to track an enhancement that would 
> allow Shared* (and all other flags that cause the VM to exit with code 
> other than 0) flags to be tested.
>
> http://cr.openjdk.java.net/~gziemski/8138983_rev3
>
>
> cheers
>
> On 11/10/2015 11:31 AM, gerard ziemski wrote:
>> hi all,
>>
>> I have updated the fix with rev2, incorporating feedback from David:
>>
>> - Move the metaspace constants back into metaspace code
>> - Fix test framework that specifies jsa file to be used by the 
>> "-Xshare:dump" flag tests
>>
>> http://cr.openjdk.java.net/~gziemski/8138983_rev2
>>
>>
>> cheers
>>
>>
>> On 11/06/2015 03:33 PM, gerard ziemski wrote:
>>> hi all,
>>>
>>> I have updated the fix with rev1, incorporating feedback from Dmitry:
>>>
>>> - Fix comments and indentation
>>> - Add "-XShare:dump" while testing Shared* flags
>>> - Temporarily disable testing of SharedMiscDataSize as with current 
>>> min default it exits the VM with code 2 (which is
>>> allowed by the JEP, but not the test framework). This issue is 
>>> tracked by JDK-8141650
>>>
>>> http://cr.openjdk.java.net/~gziemski/8138983_rev1
>>>
>>>
>>>
>>> cheers
>>>
>>>
>>>
>>> On 11/06/2015 09:58 AM, gerard ziemski wrote:
>>>>
>>>> hi all,
>>>>
>>>> Please review this final fix for JEP-245
>>>>
>>>> We implement the remaining runtime flags in the Shared* family.
>>>>
>>>> Summary of changes:
>>>>
>>>> #1 core fix - we factor out the constants to be used in the ranges
>>>>
>>>> src/share/vm/classfile/compactHashtable.cpp
>>>> src/share/vm/memory/metaspace.cpp
>>>> src/share/vm/memory/metaspaceShared.hpp
>>>> src/share/vm/runtime/globals.hpp
>>>>
>>>>
>>>> #2 we increase default sizes of range and constraint tables to 
>>>> minimize mallocs
>>>>
>>>> src/share/vm/runtime/commandLineFlagConstraintList.cpp
>>>> src/share/vm/runtime/commandLineFlagRangeList.cpp
>>>>
>>>>
>>>> #3 we fix a bug that I run into the OptionsValidation test 
>>>> framework while working
>>>>
>>>> test/runtime/CommandLine/OptionsValidation/common/optionsvalidation/IntJVMOption.java 
>>>>
>>>>
>>>>
>>>> #4 we add functionality to OptionsValidation test framework that we 
>>>> later use
>>>>
>>>> test/runtime/CommandLine/OptionsValidation/common/optionsvalidation/JVMOptionsUtils.java 
>>>>
>>>>
>>>>
>>>> #5 we cleanup and extend the existing test to detect a case where 
>>>> we get out of range value
>>>>
>>>> test/runtime/SharedArchiveFile/LimitSharedSizes.java
>>>>
>>>>
>>>> The fix passes RBT 
>>>> "hotspot/test/:hotspot_all,testlist,noncolo.testlist 
>>>> --add-tonga-keyword quick” and JPRT “hotspot"
>>>> tests
>>>>
>>>> References:
>>>>
>>>>      bug link: https://bugs.openjdk.java.net/browse/JDK-8138983
>>>>   open webrev: http://cr.openjdk.java.net/~gziemski/8138983_rev0
>>>>
>>>>
>>>> hg_stat:
>>>>
>>>> src/share/vm/classfile/compactHashtable.cpp |    2 +-
>>>> src/share/vm/memory/metaspace.cpp |   30 --
>>>> src/share/vm/memory/metaspaceShared.hpp |   19 +-
>>>> src/share/vm/runtime/commandLineFlagConstraintList.cpp |    2 +-
>>>> src/share/vm/runtime/commandLineFlagRangeList.cpp |    2 +-
>>>> src/share/vm/runtime/globals.hpp |   63 +++++-
>>>> test/runtime/CommandLine/OptionsValidation/common/optionsvalidation/IntJVMOption.java 
>>>> |    4 +-
>>>> test/runtime/CommandLine/OptionsValidation/common/optionsvalidation/JVMOptionsUtils.java 
>>>> |   81 +++++++
>>>> test/runtime/SharedArchiveFile/LimitSharedSizes.java |  180 
>>>> +++++++++-------
>>>>   9 files changed, 242 insertions(+), 141 deletions(-)
>>>
>>