RFR (XS) : 8141641: Runtime: implement range for ErrorLogTimeout

Dmitry Dmitriev dmitry.dmitriev at oracle.com
Tue Nov 17 17:21:57 UTC 2015


Hi Gerard,

Looks good to me!

Thanks,
Dmitry

On 17.11.2015 18:41, gerard ziemski wrote:
> hi all,
>
> I have updated the fix with rev2, incorporating feedback from David 
> and Dimitry as per the discussion on this list:
>
> - changed the type to uint64_t (the closest type we can use to 8byte 
> long)
> - max range is divided by 1000 to avoid overflow
> - os:sleep() uses seconds as per flag's comments
>
> http://cr.openjdk.java.net/~gziemski/8141641_rev2
>
>
> cheers
>
> On 11/12/2015 12:26 PM, gerard ziemski wrote:
>> hi all,
>>
>> I have updated the fix with rev1, incorporating the feedback from David:
>>
>> - Use trivial range
>>
>>
>> http://cr.openjdk.java.net/~gziemski/8141641_rev1
>>
>>
>> cheers
>>
>> On 11/10/2015 01:34 PM, gerard ziemski wrote:
>>>
>>> hi all,
>>>
>>> Please review this small fix for JEP-245, which implements range for 
>>> the last new runtime flag.
>>>
>>>      bug: https://bugs.openjdk.java.net/browse/JDK-8141641
>>>   webrev: http://cr.openjdk.java.net/~gziemski/8141641_rev0
>>>
>>>
>>> Thank you.
>>



More information about the hotspot-dev mailing list