RFR: JDK-8142333: Build failure in debugInfoRec.cpp with SS12u4

[Vladimir Kozlov]

Looks fine to me too. I can push the fix into hs-comp for you, if you want. Or it should be hs-rt?

Thanks,
Vladimir

On 11/30/15 9:12 AM, Coleen Phillimore wrote:
>
> This change seems fine (if you haven't already pushed) and seems better than my making the only the compare function
> public.  I think the compiler complained because the compare function here:
>
>   284   DIR_Chunk* match = _all_chunks->insert_sorted<DIR_Chunk::compare>(ns);
>
>
> Wasn't in the scope of the DebugInformationRecorder function.  Which is probably a bug in the Solaris C++ compiler that
> you should file, since none of the other compilers complain.
>
> Coleen
>
>
> On 11/27/15 6:19 AM, Erik Joelsson wrote:
>> You were correct, it didn't work when I built with "make INCLUDE_JMVCI=false". Here is a new webrev where that part is
>> fixed:
>>
>> http://cr.openjdk.java.net/~erikj/8142333/webrev.hotspot.01/
>>
>> (I accidentally overwrote the old one)
>>
>> It changes the other accesses to _offset to offset().
>>
>> Regarding why the patch works, Tom, could you please fill in here?
>>
>> /Erik
>>
>> On 2015-11-25 15:47, Coleen Phillimore wrote:
>>>
>>> I don't think this change will compile with INCLUDE_JVMCI off either.
>>> Coleen
>>>
>>> On 11/25/15 4:02 AM, Erik Joelsson wrote:
>>>> Hello,
>>>>
>>>> The following new build failure has appeared in the hotspot build when using the proposed new compiler version on
>>>> Solaris, SS12u4.
>>>>
>>>> "/opt/jprt/jprtadm/erik/jdk9-dev/hotspot/src/share/vm/code/debugInfoRec.cpp", line 281: Error: static
>>>> DIR_Chunk::compare(DIR_Chunk*const&, DIR_Chunk*const&) is not accessible from
>>>> GrowableArray<DIR_Chunk*>::insert_sorted<&DIR_Chunk::compare>(DIR_Chunk*&).
>>>> "/opt/jprt/jprtadm/erik/jdk9-dev/hotspot/src/share/vm/code/debugInfoRec.cpp", line 281: Where: While instantiating
>>>> "GrowableArray<DIR_Chunk*>::insert_sorted<&DIR_Chunk::compare>(DIR_Chunk*&)".
>>>> "/opt/jprt/jprtadm/erik/jdk9-dev/hotspot/src/share/vm/code/debugInfoRec.cpp", line 281: Where: Instantiated from
>>>> non-template code.
>>>>
>>>> Tom Rodriguez provided a patch and I have verified that it solves the issue. Since this is blocking us upgrading
>>>> compilers on Solaris, I am taking the liberty of posting it for review so we may get this resolved quickly.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8142333
>>>> Webrev: http://cr.openjdk.java.net/~erikj/8142333/webrev.hotspot.01/
>>>>
>>>> /Erik
>>>
>>
>