RFR: JDK-8138692: libjsig compilation is missing EXTRA_CFLAGS on macosx
Erik Joelsson
erik.joelsson at oracle.com
Thu Oct 1 13:31:36 UTC 2015
Hello,
Please review this trivial fix for compiling libjsig on macosx.
The compilation of libjsig on macosx is currently not getting the
EXTRA_CFLAGS supplied to the hotspot build. This means any kind of
sysroot/sdkname setting from configure isn't honored. Historically this
has likely not mattered at all, but in the compiler upgrade project, it
matters a great deal.
Bug: https://bugs.openjdk.java.net/browse/JDK-8138692
Patch:
diff -r 983c56341c80 make/bsd/makefiles/jsig.make
--- a/make/bsd/makefiles/jsig.make
+++ b/make/bsd/makefiles/jsig.make
@@ -62,7 +62,7 @@
$(LIBJSIG): $(JSIGSRCDIR)/jsig.c $(LIBJSIG_MAPFILE)
@echo $(LOG_INFO) Making signal interposition lib...
$(QUIETLY) $(CC) $(SYMFLAG) $(ARCHFLAG) $(SHARED_FLAG) $(PICFLAG) \
- $(LFLAGS_JSIG) $(JSIG_DEBUG_CFLAGS) -o $@ $<
+ $(LFLAGS_JSIG) $(JSIG_DEBUG_CFLAGS)
$(EXTRA_CFLAGS) -o $@ $<
ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1)
ifeq ($(OS_VENDOR), Darwin)
$(DSYMUTIL) $@
/Erik
More information about the hotspot-dev
mailing list