RFR (XS) 8078295 - hotspot test_env.sh can set VM_CPU incorrectly
Daniel D. Daugherty
daniel.daugherty at oracle.com
Mon Oct 5 13:31:11 UTC 2015
On 9/29/15 1:18 PM, Ioi Lam wrote:
> Please review a very small fix:
>
> http://cr.openjdk.java.net/~iklam/8078295_test_env_sh.01/
test/test_env.sh
No comments.
Thumbs up.
Dan
>
> Bug: [TESTBUG] hotspot test_env.sh can set VM_CPU incorrectly
>
> https://bugs.openjdk.java.net/browse/JDK-8078295
>
> Summary of fix:
>
> test_env.sh uses the following to get information such as VM_CPU
>
> ${TESTJAVA}${FS}bin${FS}java ${TESTOPTS} -Xinternalversion >
> vm_version.out 2>&1
>
> VM_CPU="unknown"
> grep "arm" vm_version.out > ${NULL}
> if [ $? = 0 ]
> then
> VM_CPU="arm"
> fi
>
> However, the internal version may contain arbitrary text (from the
> user name and pwd)
> such as "arm", which would cause VM_CPU to have incorrect value.
>
> The fix is to filter out the arbitrary text using a sed script
> (please see the bug report
> for details and sample output):
>
> ${TESTJAVA}${FS}bin${FS}java ${TESTOPTS} -Xinternalversion \
> | sed -e 's/[(][^)]*[)]//g' -e 's/ by "[^"]*"//g' \
> > vm_version.out 2>&1
>
> Tests:
>
> JPRT
> RBT, with the following tests
> hotspot/test/:hotspot_all
> vm.parallel_class_loading.testlist
> vm.regression.testlist
> vm.runtime.testlist
> vm.tmtools.testlist)
>
> Thanks
> - Ioi
>
More information about the hotspot-dev
mailing list