RFR: 8138659: Speed up InstanceKlass subclass discrimination

Coleen Phillimore coleen.phillimore at oracle.com
Wed Oct 7 23:35:09 UTC 2015


Kim,

This looks *very* nice.   Thank you for doing this:

+    return static_cast<InstanceMirrorKlass*>(k);


For bonus points can you change this to a static_cast<>  ???

   // Casting from Klass*
   static InstanceKlass* cast(Klass* k) {
     assert(k == NULL || k->is_klass(), "must be");
     assert(k == NULL || k->oop_is_instance(), "cast to InstanceKlass");
     return (InstanceKlass*) k;
   }

I don't have to see it though.

Thanks!
Coleen

On 10/7/15 12:02 PM, Kim Barrett wrote:
> Another round, with some name changes that resulted from discussion
> with StefanK and Coleen.  Also, Coleen convinced me some functions
> weren't needed.
>
> New full and incremental webrevs:
> http://cr.openjdk.java.net/~kbarrett/8138659/webrev.02/
> http://cr.openjdk.java.net/~kbarrett/8138659/webrev.02.inc/
>



More information about the hotspot-dev mailing list