RFR: 8042893 and 8042894: PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC needs to be removed from source files

Bengt Rutisson bengt.rutisson at oracle.com
Thu Oct 8 06:57:54 UTC 2015


Hi David,

Nice cleanup! Thanks for doing this!

On 2015-10-07 17:39, David Lindholm wrote:
> Hi,
>
> Please review the following patch that removes 
> PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC from all source files in HotSpot. 
> It also fixes all compiler warnings caused by format strings that were 
> previously silenced by this pragma.
>
> This patch is a joint effort by me and Goetz Lindenmaier.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8042893
> Bug: https://bugs.openjdk.java.net/browse/JDK-8042894
> Webrev: http://cr.openjdk.java.net/~david/JDK-8042893-8042894/webrev.00/

I've browsed the webrev. All changes that I looked closer at looks good 
and I with all the PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC gone and it still 
compiles I think it should be fine.

Looks good.

Bengt

>
> Testing: Passed JPRT
>
>
> Thanks,
> David



More information about the hotspot-dev mailing list