RFR 8140274: methodHandles and constantPoolHandles should be passed as const references

Coleen Phillimore coleen.phillimore at oracle.com
Fri Oct 23 17:51:46 UTC 2015



On 10/23/15 1:44 PM, serguei.spitsyn at oracle.com wrote:
> Hi Coleen,
>
> Thank you for the fix!
> It looks good.
>
> I'm curious, if the scanning time for MetadataOnStackMark saved with 
> this change is noticeable.

Thank you Serguei for looking at this.

I didn't measure the MetadataOnStackMark savings.   I'm not sure if it'd 
show because there usually aren't an order of magnitude more entries 
when we do the scan.   I think there may be some savings in the calls in 
general by not calling the constructors and destructors though.

Thanks!
Coleen
>
> Thanks,
> Serguei
>
> On 10/22/15 14:21, Coleen Phillimore wrote:
>> Summary: modified code to use const reference parameters
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/8140274.01/
>> bug link https://bugs.openjdk.java.net/browse/JDK-8140274.01
>>
>> A test of tolerance for tedium!  Best to look at the patch for this 
>> one.  See bug for how much size it saved in libjvm.so file.
>>
>> Tested with JPRT, and jtreg tests.
>>
>> Thanks,
>> Coleen
>



More information about the hotspot-dev mailing list