RFR 8140274: methodHandles and constantPoolHandles should be passed as const references

Christian Thalinger christian.thalinger at oracle.com
Fri Oct 23 21:32:27 UTC 2015


> On Oct 23, 2015, at 10:51 AM, Coleen Phillimore <coleen.phillimore at oracle.com> wrote:
> 
> 
> Thanks, Chris for browsing through.
> 
> On 10/23/15 2:26 PM, Christian Thalinger wrote:
>>> On Oct 22, 2015, at 11:21 AM, Coleen Phillimore <coleen.phillimore at oracle.com> wrote:
>>> 
>>> Summary: modified code to use const reference parameters
>>> 
>>> open webrev at http://cr.openjdk.java.net/~coleenp/8140274.01/
>> I browsed through all the changes and they looked good.  Really, I rely on the compilers to complain if we are using const where we shouldn’t.
> 
> Here we are not using consts so I added them and then the compiler told me where to put the rest....  :)

Very nice of him.

>> 
>>> bug link https://bugs.openjdk.java.net/browse/JDK-8140274.01
>> You need to stop sending these .01 bug links… they don’t work :-)
> 
> I should fix my cut/paste webrev script.
> 
> Thanks!
> Coleen
>> 
>>> A test of tolerance for tedium!  Best to look at the patch for this one.  See bug for how much size it saved in libjvm.so file.
>>> 
>>> Tested with JPRT, and jtreg tests.
>>> 
>>> Thanks,
>>> Coleen
> 



More information about the hotspot-dev mailing list