RFR 8139163: InstanceKlass::cast passes through NULL

Coleen Phillimore coleen.phillimore at oracle.com
Sat Oct 24 01:09:30 UTC 2015



On 10/23/15 6:44 PM, Kim Barrett wrote:
> On Oct 23, 2015, at 5:34 PM, Coleen Phillimore <coleen.phillimore at oracle.com> wrote:
>> On 10/23/15 4:30 PM, Kim Barrett wrote:
>>> src/share/vm/oops/klass.hpp
>>>
>>> Pre-existing: Why aren't Klass::vtable and Klass::vtable_length pure
>>> virtual?
>> I don't know!   yes, they should be and it feels a lot safer to have them pure virtual so nobody gets null/0 by mistake.
> Feel free to slip that change in.  Or file an RFE if not comfortable with including here.

It's not a risky or hard change so I made it.
>
>> Do you want to see another webrev with the additional cleanups?
> Yes, please.  They’re pretty straightforward, but there were enough of them…

See if you can find them now.

open webrev at http://cr.openjdk.java.net/~coleenp/8139163.02/
bug link https://bugs.openjdk.java.net/browse/JDK-8139163

Thanks!
Coleen
>



More information about the hotspot-dev mailing list