RFR 8139203: Consistent naming for klass type predicates

Coleen Phillimore coleen.phillimore at oracle.com
Tue Oct 27 21:15:51 UTC 2015



On 10/27/15 1:34 PM, John Rose wrote:
> On Oct 27, 2015, at 10:18 AM, Coleen Phillimore <coleen.phillimore at oracle.com> wrote:
>> This is a simple renaming with 2 minor cleanups in jvm.cpp, and removed the oop functions also.
> Nice!  And you can delete a little more:  Move the "_slow" versions into DEBUG_ONLY builds, or even kill them off.

I will move the slow versions under #ifdef ASSERT (as is 
assert_same_query).  I'd rather not remove them because some people I 
know have been eyeing the (I think) two extra bits in the 
layout_helper.  They could mess things up so we should leave the "slow" 
verification.

Thanks!!
Coleen

>
> Archaeological Note: The Klass virtuals were the original functions (sans "_slow"), but now exist only in order to provide a cross-check on the validity of the LH-based tests.  The LH-based tests appear to be working correctly now.  :-)
>
> — John



More information about the hotspot-dev mailing list