RFR(XS): 8132980: Improve stability of whitebox methods getCodeBlob and freeCodeBlob
Stas Smirnov
stanislav.smirnov at oracle.com
Wed Sep 9 16:42:34 UTC 2015
Hi,
changes looks good, one small remark, in one case when "addr == 0" you
just make a return and in another case you THROW_MSG_NULL is there any
specific reason for a different way of handling the same condition?
On 08.09.2015 19:37, Kirill Zhaldybin wrote:
> Hi!
>
> Could you please review the following patch for WB methods?
>
> I added checks for negative size and null address values (where
> applicable) for getCodeBlob, allocateCodeBlob and freeCodeBlob, added
> regression test.
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8132980
> Webrev:
> hotspot:
> http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8132980/webrev.00/
>
> Thanks,
> Kirill
More information about the hotspot-dev
mailing list