RFR (XXL): JEP 243: Java-Level JVM Compiler Interface

Christian Thalinger christian.thalinger at oracle.com
Fri Sep 18 17:02:33 UTC 2015


> On Sep 18, 2015, at 1:14 AM, Roland Westrelin <roland.westrelin at oracle.com> wrote:
> 
>> http://cr.openjdk.java.net/~kvn/JVMCI/webrev.hotspot/ <http://cr.openjdk.java.net/~kvn/JVMCI/webrev.hotspot/>
> 
> sharedRuntime.cpp
> 
> 539   if (!((NativeInstruction*)pc)->is_safepoint_poll()) {
> 540     tty->print_cr("bad pc: %p", pc);
> 541     Disassembler::decode(cb);
> 542     assert(false, "Only polling locations are used for safepoint");
> 543   }
> 
> Shouldn’t that be under #idef ASSERT?

Either that or make the assert a fatal.

> 
> I looked at the c++ files except src/share/vm/gc stuff. I didn’t go over the java files or makefile changes. What I looked at is ok.

Thank you.

> 
> Roland.



More information about the hotspot-dev mailing list