RFR(S): 8027565 - Enable /d2Zi+ when building with Visual Studio 2013

[Magnus Ihse Bursie]

On 2015-09-22 16:40, Christian Tornqvist wrote:
> Hi Magnus,
>
>> When was the /d2Zi+ switch introduced?
> As Dan pointed out, it was introduced as an undocumented switch in VS2012
> and was planned to be an official switch in VS2013. The official switch was
> introduced in VS2013 Update 3 and in VS2015 this switch is on by default.

Fair enough. There seemed to be no deprecation warning for /d2Zi+ 
either, so I guess that's fine going forward too.

Looks good for me, then. Nice to see debugging data for optimized code, 
way to go Microsoft (and Christian)! :)

/Magnus

>
> Thanks,
> Christian
>
> -----Original Message-----
> From: Magnus Ihse Bursie [mailto:magnus.ihse.bursie at oracle.com]
> Sent: Tuesday, September 22, 2015 5:06 AM
> To: Christian Tornqvist <christian.tornqvist at oracle.com>;
> hotspot-dev at openjdk.java.net
> Subject: Re: RFR(S): 8027565 - Enable /d2Zi+ when building with Visual
> Studio 2013
>
> On 2015-09-22 02:36, Christian Tornqvist wrote:
>> Hi everyone,
>>
>>
>> Please review this small change that enables generation of enhanced
>> debug symbols for optimized code on Windows. The switch is available
>> as /d2Zi+ prior to Update 3, when it was officially added as /Zo. Both
>> /Zo and /d2Zi+ works with VS2013 Update 3 and later. More information
>> about this switch can be found at
>> https://msdn.microsoft.com/en-us/library/dn785163.aspx
> Christian,
>
> When was the /d2Zi+ switch introduced?
>
> /Magnus
>
>>    
>>
>> I've verified the change by building locally with VS2013 Update 4 and
>> with JPRT that has the older VS2013 (non-update) version.
>>
>>    
>>
>> Webrev:
>>
>> http://cr.openjdk.java.net/~ctornqvi/webrev/8027565/webrev.00/
>>
>>    
>>
>> Bug:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8027565
>>
>>    
>>
>> Thanks,
>>
>> Christian
>>
>