RFR (XXL): JEP 243: Java-Level JVM Compiler Interface

[Christian Thalinger]

> On Sep 23, 2015, at 1:43 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> 
> Can't say much about top changes but they work so I assume they are correct.
> 
> I looked on C++ code.
> 
> We have a lot #if defined(COMPILER2) || INCLUDE_JVMCI
> May be we should define one value #if defined(HIGH_TIER_COMPILER) ?

I’m not sure about this.  We can keep it in mind and change it later if it turns out it would be useful.

> 
> vmStructs_x86.hpp we may need to add new VM_Version values added recently:
> 
>    CPU_RTM      = (1 << 24), // Restricted Transactional Memory instructions
>    CPU_ADX      = (1 << 25),
>    CPU_AVX512F  = (1 << 26), // AVX 512bit foundation instructions
> …

Might be a good idea.  I did add all of them to jdk.internal.jvmci.amd64.AMD64.CPUFeature but I didn’t add code to process them in jdk.internal.jvmci.hotspot.amd64.AMD64HotSpotJVMCIBackendFactory.computeFeatures(HotSpotVMConfig).  Do you want me to do that too?

http://hg.openjdk.java.net/graal/graal-jvmci-9/hotspot/rev/f88785857043 <http://hg.openjdk.java.net/graal/graal-jvmci-9/hotspot/rev/f88785857043>

> 
> Several places (14) in new code use %p which we should change to PRT_FROMAT or similar.

I only found 13:

http://hg.openjdk.java.net/graal/graal-jvmci-9/hotspot/rev/83f08ad44950 <http://hg.openjdk.java.net/graal/graal-jvmci-9/hotspot/rev/83f08ad44950>

> 
> Vladimir
> 
> On 9/22/15 7:52 AM, Christian Thalinger wrote:
>> Thank you, Igor.
>> 
>>> On Sep 21, 2015, at 1:48 PM, Igor Veresov <igor.veresov at oracle.com> wrote:
>>> 
>>> I’ve seen it all before, but I went through it one more time in its entirety and it looks good.
>>> 
>>> igor
>>> 
>>>> On Sep 21, 2015, at 3:24 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
>>>> 
>>>>> 
>>>> 
>>>> Here are new webrevs against hs-comp:
>>>> 
>>>> http://cr.openjdk.java.net/~twisti/8136421/webrev/
>>>> http://cr.openjdk.java.net/~twisti/8136421/hotspot/webrev/
>>>> 
>>