RFR: 8080775: Better argument formatting for assert() and friends
Kim Barrett
kim.barrett at oracle.com
Mon Sep 28 17:11:23 UTC 2015
On Sep 28, 2015, at 11:37 AM, David Lindholm <david.lindholm at oracle.com> wrote:
>
> Kim and Per,
>
> Thank you! I have made fixes for all your comments, the latest webrev is available here:
>
> http://cr.openjdk.java.net/~david/JDK-8080775/webrev.03/
>
> Kim, I have left the casts in the code, as you say this should be fixed in another change.
------------------------------------------------------------------------------
> src/share/vm/gc/g1/g1BlockOffsetTable.cpp
> 364 assert((_array->offset_array(orig_index) == 0 &&
> 365 blk_start == boundary) ||
> 366 (_array->offset_array(orig_index) > 0 &&
> 367 _array->offset_array(orig_index) <= N_words),
>
> Indentation of 366 and 367 are wrong.
webrev.03 has
364 assert((_array->offset_array(orig_index) == 0 &&
365 blk_start == boundary) ||
366 (_array->offset_array(orig_index) > 0 &&
367 _array->offset_array(orig_index) <= N_words),
Lines 365 and 367 should be indented one more space.
------------------------------------------------------------------------------
Otherwise, looks good. I don't need a new webrev for the above.
More information about the hotspot-dev
mailing list