RFR (XS) 8078295 - hotspot test_env.sh can set VM_CPU incorrectly

[Dean Long]

Looks fine to me, as long as the new output line

115 echo "INT_VERSION=`cat vm_version.out 2>&1`"

isn't going to confuse any scripts.

dl

On 9/29/2015 12:18 PM, Ioi Lam wrote:
> Please review a very small fix:
>
> http://cr.openjdk.java.net/~iklam/8078295_test_env_sh.01/
>
> Bug: [TESTBUG] hotspot test_env.sh can set VM_CPU incorrectly
>
>     https://bugs.openjdk.java.net/browse/JDK-8078295
>
> Summary of fix:
>
>     test_env.sh uses the following to get information such as VM_CPU
>
>         ${TESTJAVA}${FS}bin${FS}java ${TESTOPTS} -Xinternalversion > 
> vm_version.out 2>&1
>
>         VM_CPU="unknown"
>         grep "arm" vm_version.out > ${NULL}
>         if [ $? = 0 ]
>         then
>           VM_CPU="arm"
>         fi
>
>     However, the internal version may contain arbitrary text (from the 
> user name and pwd)
>     such as "arm", which would cause VM_CPU to have incorrect value.
>
>     The fix is to filter out the arbitrary text using a sed script 
> (please see the bug report
>     for details and sample output):
>
>         ${TESTJAVA}${FS}bin${FS}java ${TESTOPTS} -Xinternalversion \
>             | sed -e 's/[(][^)]*[)]//g' -e 's/ by "[^"]*"//g' \
>             > vm_version.out 2>&1
>
> Tests:
>
>     JPRT
>     RBT, with the following tests
>        hotspot/test/:hotspot_all
>        vm.parallel_class_loading.testlist
>        vm.regression.testlist
>        vm.runtime.testlist
>        vm.tmtools.testlist)
>
> Thanks
> - Ioi