RFR: 8153254: Delegate (v)write from Log to LogTagSet

Robbin Ehn robbin.ehn at oracle.com
Mon Apr 4 07:43:51 UTC 2016


Hi Stefan

On 04/04/2016 09:34 AM, Stefan Karlsson wrote:
> Hi Robbin,
>
> On 2016-04-01 10:53, Robbin Ehn wrote:
>> Hi all,
>>
>> Please review this patch.
>>
>> This moves log writes methods to LogTagSet.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8153254
>> Webrev: http://cr.openjdk.java.net/~rehn/8153254/webrev/
>
> This looks good to me.
>
> The indention is wrong in the parameter initialization list and the
> includes are incorrectly sorted (These issues come from the original
> patch :).

:)

Fixed (no webrev).

Thanks Stefan!

/Robbin

>
> Thanks for changing this,
> StefanK
>
>>
>> Tested with internal vm test and jprt.
>>
>> Thanks!
>>
>> /Robbin
>>
>


More information about the hotspot-dev mailing list