RFR: 8153254: Delegate (v)write from Log to LogTagSet

Robbin Ehn robbin.ehn at oracle.com
Mon Apr 4 13:14:10 UTC 2016


Hi Kim

On 04/04/2016 10:24 AM, Kim Barrett wrote:
>> On Apr 1, 2016, at 4:53 AM, Robbin Ehn <robbin.ehn at oracle.com> wrote:
>>
>> Hi all,
>>
>> Please review this patch.
>>
>> This moves log writes methods to LogTagSet.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8153254
>> Webrev: http://cr.openjdk.java.net/~rehn/8153254/webrev/
>>
>> Tested with internal vm test and jprt.
>>
>> Thanks!
>>
>> /Robbin
>
> I think LogTagSetMapping might need to have a GuardTag template
> parameter added, similar to that of Log, so that things like
>
> LogTagSetMapping< LOG_TAGS(__VAR_ARGS__) >
>
> can be used in some of Stefan's planned followups to this change.

I also found a other need to for the guards.
(we use LogTagSetMapping directly in some internal code)

So I added them back.

>
> Otherwise, looks good.
>

Thanks!

(pushing without new webrev)

/Robbin


More information about the hotspot-dev mailing list