RFR(XS): 8153275: Zero JVM fails to initialize after JDK-8152440

Severin Gehwolf sgehwolf at redhat.com
Tue Apr 5 09:30:14 UTC 2016


On Tue, 2016-04-05 at 09:48 +0100, Andrew Haley wrote:
> On 04/04/16 18:44, Severin Gehwolf wrote:
> > 
> > Hi,
> > 
> > Could somebody please sponsor and review the following Zero-only fix?
> > The fix for JDK-8152440 was incorrect in that it set the value
> > for InitArrayShortSize to an illegal value (-1) failing constraint
> > validation. Albeit not being used it must still pass constraint
> > validation. Otherwise, the JVM fails to initialize and all bets are
> > off. Thoughts?
> > 
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8153275
> > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8153275/webrev.01/
> OK, but please make the comment clearer.  I didn't understand it.
> 
>  "the allowed range [ 0 ... 9223372036854775807 ]"
> 
> is much clearer.

Thanks for the review!

Updated webrev:
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8153275/webrev.02/

Cheers,
Severin



More information about the hotspot-dev mailing list