RFR: 8153749 - New capability can_generate_early_class_hook_events
Dmitry Samersoff
dmitry.samersoff at oracle.com
Thu Apr 14 09:24:34 UTC 2016
Serguei,
Looks good for me.
-Dmitry
On 2016-04-14 11:24, serguei.spitsyn at oracle.com wrote:
> Please, review the Jigsaw-related fix for:
> https://bugs.openjdk.java.net/browse/JDK-8153749
>
>
> Hotspot webrev:
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8153749-Jigsaw-newcap.hs1/
>
>
> Jdk webrev:
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/jdk/8153749-Jigsaw-newcap.jdk1/
>
>
>
> Summary:
>
> This is a Jigsaw related enhancement.
> Some agents need to get a CFLH event for classes loaded in the
> primordial phase.
> This is not possible in JDK 9 because existing agents may instrument
> code in the
> primordial or start phase before the module system has completed
> initialization.
>
> We introduce a new capability: can_generate_early_class_hook_events.
> If this capability and can_generate_all_class_hook_events are enabled
> then
> the CFLH event could be posted for classes loaded in the primordial
> phase.
> We leave can_generate_early_vmstart as is, no changes.
>
> This enhancement needs a CCC request filed.
> I will file it once the JVMTI spec changes are reviewed.
>
>
> Testing:
> Altered the nsk.jvmti co-located test
> nsk/jvmti/ClassFileLoadHook/classfloadhk002
> to enable the can_generate_early_class_hook_events and checked that
> new CFLH events
> are posted in the primordial phase and also they are not posted
> otherwise.
>
>
> Thanks,
> Serguei
>
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
More information about the hotspot-dev
mailing list