RFR(XS): 8153275: Zero JVM fails to initialize after JDK-8152440

Severin Gehwolf sgehwolf at redhat.com
Mon Apr 18 09:42:09 UTC 2016


On Thu, 2016-04-14 at 16:59 -0400, Coleen Phillimore wrote:
> Hi,  I've hit this bug and reviewed it and will sponsor it.

Thanks Coleen! An exported changeset of the latest patch is here:
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8153275/JDK-8153275-jdk9-hotspot.export.patch

Cheers,
Severin

> Thanks,
> Coleen
> 
> 
> On 4/6/16 4:38 AM, Severin Gehwolf wrote:
> > 
> > On Tue, 2016-04-05 at 11:30 +0200, Severin Gehwolf wrote:
> > > 
> > > On Tue, 2016-04-05 at 09:48 +0100, Andrew Haley wrote:
> > > > 
> > > > On 04/04/16 18:44, Severin Gehwolf wrote:
> > > > > 
> > > > > 
> > > > > Hi,
> > > > > 
> > > > > Could somebody please sponsor and review the following Zero-
> > > > > only
> > > > > fix?
> > > > > The fix for JDK-8152440 was incorrect in that it set the
> > > > > value
> > > > > for InitArrayShortSize to an illegal value (-1) failing
> > > > > constraint
> > > > > validation. Albeit not being used it must still pass
> > > > > constraint
> > > > > validation. Otherwise, the JVM fails to initialize and all
> > > > > bets
> > > > > are
> > > > > off. Thoughts?
> > > > > 
> > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8153275
> > > > > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8153
> > > > > 275/
> > > > > webrev.01/
> > > > OK, but please make the comment clearer.  I didn't understand
> > > > it.
> > > > 
> > > >   "the allowed range [ 0 ... 9223372036854775807 ]"
> > > > 
> > > > is much clearer.
> > > Thanks for the review!
> > > 
> > > Updated webrev:
> > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8153275/webrev.0
> > > 2/
> > Could somebody sponsor this please?
> > 
> > Thanks,
> > Severin



More information about the hotspot-dev mailing list