RFR [9] 8153756: jdk.vm.ci should not depend on sun.misc ( jdk.unsupported module )
Chris Hegarty
chris.hegarty at oracle.com
Mon Apr 18 19:51:36 UTC 2016
> On 18 Apr 2016, at 20:32, Christian Thalinger <christian.thalinger at oracle.com> wrote:
>
>
>> On Apr 18, 2016, at 5:07 AM, Chris Hegarty <chris.hegarty at oracle.com <mailto:chris.hegarty at oracle.com>> wrote:
>>
>> Refactoring due to JEP 260 [1] has moved the "real" Unsafe to
>> jdk.internal.misc. All JDK modules, if they require Unsafe,
>> should depend on a qualified export of jdk.internal.misc from
>> the base module, rather than Unsafe in the jdk.unsupported module.
>> The base module already exports jdk.internal.misc to the jdk.vm.ci
>> module.
>>
>> This issue updates all usages of sun.misc.Unsafe to
>> jdk.internal.misc.Unsafe, in the jdk.vm.ci module.
>>
>> http://cr.openjdk.java.net/~chegar/8153756/ <http://cr.openjdk.java.net/~chegar/8153756/>
>
> src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotMethodData.java
>
> -import sun.misc.Unsafe;
> This file and others have Unsafe references in Javadoc that's why the import is required.
There are two files that have imports but no static references, as you
say these are for javadoc. I can reinstate an updated import, or inline
the single file javadoc usage in the @link? Whichever you prefer.
> I assume you did run all compiler/jvmci tests?
Yes, all hotspot testset pass.
-Chris H
>> https://bugs.openjdk.java.net/browse/JDK-8153756 <https://bugs.openjdk.java.net/browse/JDK-8153756>
>>
>> The webrev is against jdk9/dev, but I intend to push this through
>> hs-comp.
>>
>> -Chris.
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8132928
>
More information about the hotspot-dev
mailing list