[8u] RFR: JDK-8141551: C2 can not handle returns with incompatible interface arrays

[Shafi Ahmad]

Hi All,

Please review. It contains the additional change of removing @modules and below change to make the test case run in jdk8.

New webrev link: http://cr.openjdk.java.net/~rpatil/8141551/webrev.01/

I run the newly added jtreg test individually and it passes after the change and also run all other hotspot test.
 
Regards,
Shafi

-----Original Message-----
From: Shafi Ahmad 
Sent: Tuesday, April 19, 2016 11:46 AM
To: Vladimir Kozlov; Volker Simonis
Subject: RE: [8u] RFR: JDK-8141551: C2 can not handle returns with incompatible interface arrays

Thanks Vladimir for reviewing it and clarifying my doubts. In jdk9 sun/hotspot/Whitebox is inside jdk9-dev/test/lib where as in jdk8 same is inside jdk8u-dev/hotspot/test/testlibrary/whitebox. So with the below change this test is running fine. 

diff -r ac05b856c6bc test/compiler/types/TestMeetIncompatibleInterfaceArrays.java
--- a/test/compiler/types/TestMeetIncompatibleInterfaceArrays.java	Tue Apr 19 10:31:00 2016 +0530
+++ b/test/compiler/types/TestMeetIncompatibleInterfaceArrays.java	Tue Apr 19 11:34:52 2016 +0530
@@ -27,7 +27,7 @@
  * @summary C2 can not handle returns with inccompatible interface arrays
  * @modules java.base/jdk.internal.org.objectweb.asm
  *          java.base/sun.misc
- * @library /testlibrary /../../test/lib
+ * @library /testlibrary /testlibrary/whitebox/
  * @build sun.hotspot.WhiteBox
  * @run main ClassFileInstaller sun.hotspot.WhiteBox
  *                              sun.hotspot.WhiteBox$WhiteBoxPermission
shafi at shafi-ahmad:~/Java/jtreg/lib$ java -jar jtreg.jar -jdk:/home/shafi/Java/jdk8/jdk8u-dev/build/linux-x86_64-normal-server-release/jdk/ /home/shafi/Java/jdk8/jdk8u-dev/hotspot/test/compiler/types/TestMeetIncompatibleInterfaceArrays.java
Test results: passed: 1
Report written to /home/shafi/Java/jtreg/lib/JTreport/html/report.html
Results written to /home/shafi/Java/jtreg/lib/JTwork

On top of above change I will remove the @modules and after running the jtreg tests I will send incremental change for review.

Regards,
Shafi 
 

-----Original Message-----
From: Vladimir Kozlov
Sent: Monday, April 18, 2016 9:48 PM
To: Volker Simonis; Shafi Ahmad
Cc: HotSpot Open Source Developers
Subject: Re: [8u] RFR: JDK-8141551: C2 can not handle returns with incompatible interface arrays

On 4/18/16 5:39 AM, Volker Simonis wrote:
> Hi Shafi,
>
> please not that I'm not a formal jdk8u reviewer.
>
> The change to the source files looks good. Where did the change not 
> applied cleanly?

Looks like it is new() vs new(Compiler) Node allocation known difference.
I verified that changes are matching jdk 9 changes except new() difference.

>
> I'm only a little worried about the test because it uses the 
> '@modules' tag. But if it runs and executed fine with jdk8u it's fine.


The test should not have @modules for jdk8u since it is not supported there.

JPRT does not run jtreg tests when testing jdk8u sources (only one very simple ExecuteInternalVMTests.java):

http://hg.openjdk.java.net/jdk8u/jdk8u-dev/hotspot/file/d025821b6b6d/test/TEST.groups#l131

You should run jtreg tests yourself using your jdk8u as test jdk.

Please, verify results of your testing before pushing.

Thanks,
Vladimir

>
> Thanks for backporting this to jdk8,
> Volker
>
>
> On Mon, Apr 18, 2016 at 12:26 PM, Shafi Ahmad <shafi.s.ahmad at oracle.com> wrote:
>> Hi,
>>
>>
>>
>> Please review the backport of bug: "JDK-8141551: C2 can not handle returns with incompatible interface arrays" to jdk8u.
>>
>> Please note the backport is not clean.
>>
>>
>>
>> Webrev: http://cr.openjdk.java.net/~rpatil/8141551/webrev.00/
>>
>> Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8141551
>>
>> Original patch pushed to jdk9: 
>> http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/b425a78e8512
>>
>>
>>
>> Test:  Run jprt.
>>
>>
>>
>> Regards,
>>
>> Shafi
>>
>>