RFR(s): 8154210: Zero: Better byte behaviour

[Andrew Hughes]

----- Original Message -----
> 
> This looks good.  Sorry, I thought I'd fixed this but apparently not
> correctly.
> I'll sponsor it.
> 

There's a rather chequered history to this. We didn't see 8146518
before it appeared in the public push of 8u91. Andrew Haley thus developed
our own fix which covered both the issues fixed in 8146518 and
the ones you see in this changeset.

Up on merging the upstream u91, I first tested out the upstream version
without our fix. It worked fine on a debug build, but immediately crashed
on a product build. Hence the need for this patch.

It was quite possible to entirely miss these remaining changes:

1. The jump table is only used on product builds (USELABELS needs to
be defined). We fell over this ourselves when the initial patch missed
a comma in that same table.

2. The address issue only shows up on 64-bit big-endian architectures.
So you'll see it on ppc64(be) if you disable the JIT and on s390x, but
not on other architectures.

> Coleen
> 
> 

-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222