RFR(XXS): 8164521 - compiler/rangechecks/TestRangeCheckSmearing.java is missing @build for sun.hotspot.WhiteBox

Christian Tornqvist christian.tornqvist at oracle.com
Sat Aug 20 13:33:20 UTC 2016


Hi Coleen, 

Thanks for the review, this test is not in the set of tests for JPRT. It may
also pass if a previous test in the same folder and process has already
built sun.hotspot.WhiteBox, which is probably why I didn't see it when I ran
all the hotspot jtreg tests 50 times before pushing :)

Thanks,
Christian

-----Original Message-----
From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of
Coleen Phillimore
Sent: Saturday, August 20, 2016 9:21 AM
To: hotspot-dev at openjdk.java.net
Subject: Re: RFR(XXS): 8164521 -
compiler/rangechecks/TestRangeCheckSmearing.java is missing @build for
sun.hotspot.WhiteBox

Christian,
this looks good.   How did this one get through JPRT?
thanks,
Coleen

On 8/20/16 9:18 AM, Christian Tornqvist wrote:
> Hi everyone,
>
>   
>
> Please review this small change that fixes a mistake made in
JDK-8157957,
> the @build was supposed to be changed to build sun.hotspot.WhiteBox 
> but instead got lost somewhere on the way.
>
>   
>
> Verified fix locally.
>
>   
>
> Webrev:
>
> http://cr.openjdk.java.net/~ctornqvi/webrev/8164521/webrev.00/
>
>   
>
> Bug:
>
> https://bugs.openjdk.java.net/browse/JDK-8164521
>
>   
>
> Thanks,
>
> Christian
>




More information about the hotspot-dev mailing list