RFR(S): 8164737 - Remove Unsafe dependency from ProcessTools

[David Holmes]

Hi Christian,

On 25/08/2016 4:31 AM, Christian Tornqvist wrote:
> Hi everyone,
>
> Please review this small change that removes the unnecessary dependency on
> Unsafe from ProcessTools. Jdk.test.lib.ProcessTools use some methods from
> jdk.test.lib.Utils which has the getUnsafe() method, all tests that use
> ProcessTools needed to have the @modules java.base/jdk.internal.misc even if
> they don't use Unsafe.
>
> This change moves getUnsafe() into a new class:
> jdk.test.lib.unsafe.UnsafeHelper and updates the few existing tests that use
> Unsafe to use this class instead.

Okay, but I don't see any changes to any @modules for tests that use 
ProcessTools but not getUnsafe - are there none at present?

Aside: if we defined a jdk.test module would that allows us to handle 
transitive dependencies in that module definition instead of in the 
individual tests?

Thanks,
David
-----

>
>
> Webrev:
>
> http://cr.openjdk.java.net/~ctornqvi/webrev/8164737/webrev.00/
>
>
>
> Bug:
>
> https://bugs.openjdk.java.net/browse/JDK-8164737
>
>
>
> Thanks,
>
> Christian
>
>
>